feat(pipelines): add manage field to CreateCertificateStep (ARO-28053)#261
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the pipeline type system and JSON schema to support an optional manage field on the CreateCertificate step, allowing certificate management to be conditionally disabled without removing the step from pipeline configuration.
Changes:
- Added
manageas a newValuefield onCreateCertificateStep. - Extended
pipeline.schema.v1.jsonto allow themanageproperty inCreateCertificatesteps. - Updated golden fixture output and
RequiredInputs()unit test expectations to include the new field.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pipelines/types/common.go | Adds Manage Value to CreateCertificateStep and includes it in RequiredInputs() dependency collection. |
| pipelines/types/common_test.go | Extends TestRequiredInputs to cover Manage when it is input-chained. |
| pipelines/types/pipeline.schema.v1.json | Adds manage to the createCertificateStep schema properties. |
| pipelines/types/testdata/zz_fixture_TestNewPipelineFromFile.yaml | Updates the golden fixture to include the new manage field in the serialized pipeline output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geoberle
force-pushed
the
create-certificate-manage
branch
2 times, most recently
from
890002b to
60fa2b2
Compare
Comment on lines
95
to
101
| SecretKeyVault: Value{Input: &Input{StepDependency: StepDependency{ResourceGroup: "rg", Step: "step5"}}}, | ||
| SecretName: Value{Input: &Input{StepDependency: StepDependency{ResourceGroup: "rg", Step: "step6"}}}, | ||
| ApplicationId: Value{Input: &Input{StepDependency: StepDependency{ResourceGroup: "rg", Step: "step7"}}}, | ||
| CommonName: Value{Input: &Input{StepDependency: StepDependency{ResourceGroup: "rg", Step: "step8"}}}, | ||
| Manage: Value{ConfigRef: "some.config.manage"}, | ||
| }, | ||
| expected: []StepDependency{ |
geoberle
force-pushed
the
create-certificate-manage
branch
from
60fa2b2 to
50e90a5
Compare
geoberle
force-pushed
the
create-certificate-manage
branch
from
50e90a5 to
518cf59
Compare
Allow disabling certificate management per environment via an optional `manage` Value field. Some environments (e.g. FPA and GA in DEV/INT) manage certificates differently, and the pipeline step needs to be skippable without removing it from the config. https://redhat.atlassian.net/browse/ARO-28053
geoberle
force-pushed
the
create-certificate-manage
branch
from
518cf59 to
96c2899
Compare
Collaborator
|
/lgtm |
janboll
approved these changes
Jul 2, 2026
14 tasks
geoberle
added a commit
to Azure/ARO-HCP
that referenced
this pull request
Jul 3, 2026
Implements the manage gate for CreateCertificate steps, allowing pipelines to conditionally skip certificate creation based on a config-driven "Enabled"/"Disabled" value. When manage is nil (default), the step proceeds as before, preserving backward compatibility. Upstream: Azure/ARO-Tools#261 Ref: https://redhat.atlassian.net/browse/ARO-28053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow disabling certificate management via an optional
manageValue field. Value rangeEnabled/Disabled. Absence will be interpreted as enabled downstream.Why
Some environments (e.g. FPA and GA in DEV/INT) manage certificates differently, and the pipeline step needs to be skippable without removing it from the config.
https://redhat.atlassian.net/browse/ARO-28053